Typical URL Warning: not For Facebook #1
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
OERF/blog-feed-finder#1
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Created by: cogdog
Liking the response for commonly edited URLs, but expected to see it from Readme.md for entering http://facebook.com, it just offers that it redirects.
Also, and minor, on the hover box that appears for the warning on Google.com, the box disappears before I can click the hyperlink (Google Chrome in Mac OSX)
Created by: lightweight
Thanks for the feedback! Yes, with http://facebook.com, it redirects to https... thus the first message. It then mentions (second mention) that it's a common error, doesn't it? Ah, no it doesn't. Looks like the regex I'm using isn't coping if there's a "/" on the end of the URL... will fix.
Regarding the tooltip, yes, that's a tricky one... the issue is that it's gotta work for both touch and mouse-driven interfaces... Need to work out a solution. I'll shift that link into the default message (that doesn't disappear)...
Created by: cogdog
Not getting the second message for FB on my test site https://extend-domains.ecampusontario.ca/blog-feed-finder/
Created by: lightweight
Yes, in my testing, I also got that... Trying to work out what's going wrong... yes, have seen some weird behaviour - sometimes the process halts in a place that isn't final. I haven't yet been able to work out the conditions that lead to this problem. It doesn't always seem to happen.
Created by: lightweight
Ok, fixed all of this, including moving the clickable help URL into the main comment, not the tooltip.